Skip to content

Add ros1 benchmark coverage for rosbags and mcap #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add ros1 benchmark coverage for rosbags and mcap #64

wants to merge 1 commit into from
+339 −5

Conversation

siliconlad
Copy link
Owner

Summary

  • extend the benchmark utilities to generate ROS 1 odometry test data and to create matching rosbag1 and MCAP fixtures
  • add raw, decoded, and writer benchmark cases that compare rosbags with the official mcap library for ROS 1 recordings
  • include the mcap-ros1-support dependency required for the new benchmarks

Testing

  • uv run --group test pytest . (fails: existing MCAP reader tests unrelated to this change)
  • uvx pre-commit run -a

https://chatgpt.com/codex/tasks/task_e_68d0eaccb594832db1472b4fab56cad3

@siliconlad siliconlad marked this pull request as draft September 22, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
codex
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@siliconlad